Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand benchmarks #136

Merged
merged 2 commits into from
May 1, 2024
Merged

Expand benchmarks #136

merged 2 commits into from
May 1, 2024

Conversation

giarc3
Copy link
Member

@giarc3 giarc3 commented Apr 18, 2024

Makes the benchmarks match those in ironcore-alloy Rust/Kotlin

BobWall23
BobWall23 approved these changes Apr 23, 2024
View reviewed changes
benchmarks/README.md Show resolved Hide resolved
coltfred
coltfred reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@coltfred coltfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have a bigger discussion about if we want to have all the benchmarks without LD or with it and scale it up.

benchmarks/src/main/java/com/ironcorelabs/IntegrationBenchmark.java Outdated Show resolved Hide resolved
@giarc3 giarc3 merged commit 4ceeceb into main May 1, 2024
7 checks passed
@giarc3 giarc3 deleted the expand-benchmarks branch May 1, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coltfred coltfred coltfred left review comments

@BobWall23 BobWall23 BobWall23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giarc3 @coltfred @BobWall23