Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLMRequestResponse interface #194

Closed

Conversation

galenus
Copy link

@galenus galenus commented Oct 6, 2023

Initial proposal to allow providing the plugin nodes with same UI and other abilities that 'chat' node benefits from.
Matching issue: #192

  • LLMRequestResponse interface and its type guards in the 'core' package
  • using the new interface in the 'app' package

- LLMRequestResponse interface and its types guards in 'core'
- using the new interface in the 'app' package
@abrenneke
Copy link
Collaborator

Thank you for this! My main concern is storing the flag in the data of the nodes. What if we stored it as a property on the NodeImpl/PluginNodeImpl instead? That way, the data wouldn't get saved into the project file, putting unnecessary noise in it because this this is a property of the node, rather than a piece of configurable data on the node.

@galenus
Copy link
Author

galenus commented Oct 7, 2023

Thank you for this! My main concern is storing the flag in the data of the nodes. What if we stored it as a property on the NodeImpl/PluginNodeImpl instead? That way, the data wouldn't get saved into the project file, putting unnecessary noise in it because this this is a property of the node, rather than a piece of configurable data on the node.

Good idea, something I completely missed. I will change the code accordingly.
But I am not sure what to do about PromptDesigner. Maybe, I'll just revert the changes there completely for now, as the scope of the change to support it properly is much larger.

@abrenneke
Copy link
Collaborator

Yeah it's tricky, but I really appreciate you thinking about solutions to it!

@abrenneke
Copy link
Collaborator

Let me know if you ever get back to this @galenus!

@abrenneke abrenneke closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants