-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use AssemblyAI Node SDK #226
Conversation
I'd really prefer to not polyfill node APIs, because Rivet is designed to run without any kind of polyfill. Is there anything we can do to make this or your library isomorphic? It's important to me to keep Rivet isomorphic and not depend on any library that's node or browser specific. |
Got it. If we provide a browser-specific module (specify "browser" in package.json of |
I suppose that depends on the bundler used. I haven't tested it. I wonder if it's time to move this plugin out of core maybe? Like https://github.com/abrenneke/rivet-plugin-example-python-exec is the example repo. And I just wrote the docs on creating plugins too. Then you could do whatever you like with regards to libraries. |
I updated the SDK so it no longer requires polyfills in Rivet. Being built into Rivet was one of the appeals for us to contribute the integration, so I hope we can keep it in, but we can move it out if it makes more sense. |
Sure it's fine! There's really not much difference between built-in plugins and external ones at this point. Built-in plugins allow you to modify the Rivet UI though and add functionality there - if you're only adding nodes, the only real difference is that there's no "install" step and the plugin activates immediately |
We always went the fewest possible steps to success of course. ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
@Swimburger latest builds have these warnings:
|
@abrenneke The plugin doesn't rely on |
I updated the AssemblyAI plugin to use the AssemblyAI Node SDK.
This did require me to polyfill a couple of Node APIs.