Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build crashing on Node 20.9.0 or higher #266

Merged
merged 2 commits into from
Dec 14, 2023
Merged

fix: build crashing on Node 20.9.0 or higher #266

merged 2 commits into from
Dec 14, 2023

Conversation

codemile
Copy link
Collaborator

@codemile codemile commented Dec 14, 2023 •
edited
Loading

tsx was crashing during builds throwing the error TypeError [ERR_INVALID_RETURN_PROPERTY_VALUE]. Fix builds by updating tsx to latest.

Note: builds tested again in Node 20.4.0 to ensure this fix doesn't break on people running an older Node.

closes #260

@abrenneke
Copy link
Collaborator

I don't see the changes to tarballs in the cache folder being committed, can you commit those changes?

@codemile
Copy link
Collaborator Author

codemile commented Dec 14, 2023 •
edited
Loading

@abrenneke updated, the caching on Windows is diff. So I update the caches on my Mac. Was going to ask how we could fix this for both OS.

@abrenneke
Copy link
Collaborator

Yeah I wish there was a solution to the caches changes on different OSes for things like esbuild

abrenneke
abrenneke approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@abrenneke abrenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I didn't think of upgrading tsx

@abrenneke abrenneke merged commit 15e4f2f into Ironclad:main Dec 14, 2023
1 check passed
@codemile codemile deleted the fix/build-with-node-20-10 branch December 14, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrenneke abrenneke abrenneke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: yarn build fails on Node 20.9.0 (assuming higher as well)
2 participants
@codemile @abrenneke