Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when running rivet in a browser #319

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Fix error when running rivet in a browser #319

merged 1 commit into from
Jan 20, 2024

Conversation

abrenneke
Copy link
Collaborator

No description provided.

@abrenneke abrenneke requested a review from codemile January 17, 2024 20:49
codemile
codemile approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@codemile codemile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we really support browsers? because could be an opportunity to use Playwright for some automated testing.

@abrenneke
Copy link
Collaborator Author

Yeah, Rivet runs more or less okay in a browser @codemile, it just can't access the file system (well, smoothly) or use the node executor.

@abrenneke abrenneke merged commit c46bdea into main Jan 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codemile codemile codemile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abrenneke @codemile