fixes LUNA-218 add path to tauri project metadata #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrenneke
requested changes
Mar 22, 2024
| @@ -12,6 +12,7 @@ export type Project = { | |||
| title: string; | |||
| description: string; | |||
| mainGraphId?: GraphId; | |||
| path?: string; | |||
There was a problem hiding this comment.
This is going to serialize the path of the project in the project itself, which I'd like to avoid :/
Can you change the project metadata serialization to ignore this?
There was a problem hiding this comment.
pushed a change!
|
@abrenneke don't merge this, has issues! i lost work! 😢 |
|
@abrenneke Fixed a fatal error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done
This PR adds path to project metadata as optional variable. It only loads path in tauri v4 loader.
Purpose
This will allow us to use the path to automatically output files via the File Node. For example a usecase would be to automatically export datasets into csv files in the same project folder.
https://discord.com/channels/1149376303070466110/1149382713904746597/1216788570677837834