Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes LUNA-218 text port id casing #378

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

ShravanSunder
Copy link
Contributor

  • This adds an option in settings to enable text port to be upper case or preserve casing
  • impacts port rendering as an optional input
  • default is upper case as it is currently

https://discord.com/channels/1149376303070466110/1170882289417343016/1218950866464149565

}}
/>
<HelperMessage>
This WILL preserve the text fromat of the node port names. e.g. `newInputPort` will be shown instead of `NEWINPUTPORT` when enabled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This WILL preserve the text fromat of the node port names. e.g. `newInputPort` will be shown instead of `NEWINPUTPORT` when enabled
This WILL preserve the text format of the node port names. e.g. `newInputPort` will be shown instead of `NEWINPUTPORT` when enabled

Copy link
Collaborator

@abrenneke abrenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great just a typo I'll fix!

@abrenneke abrenneke merged commit 8da484a into Ironclad:main Mar 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants