Make GraphProcessor trace optional #460
Open
+84
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AryamanAgrawalIronclad
changed the title
ZhangYiJiang
requested changes
Dec 11, 2024
| @@ -75,7 +76,7 @@ export function coreCreateProcessor(project: Project, options: RunGraphOptions) | |||
| throw new Error(`Graph not found, and no main graph specified.`); | |||
| } | |||
|
|
|||
| const processor = new GraphProcessor(project, graphId as GraphId, options.registry); | |||
| const processor = new GraphProcessor(project, graphId as GraphId, options.registry, options.includeTrace); | |||
There was a problem hiding this comment.
I think it would be preferred for optional properties to be grouped into an options object so they can be specified in any order, but this class is exported out of core which technically makes it part of the public interface. While I think most users would use it through createGraphProcessor we can't update this without a breaking change, but we can at least note this for the future
Comment on lines
+877
to
+882
| if(this.#includeTrace){ | ||
| this.#emitter.emit( | ||
| 'trace', | ||
| `Node ${node.title} has required inputs nodes: ${inputNodes.map((n) => n.title).join(', ')}`, | ||
| ); | ||
| } |
There was a problem hiding this comment.
Also we should consider adding a small util to wrap this so future calls to emitting trace don't miss the check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includeTraceonly exists as an override for a user who would like to disable traces for their graph runs.