-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add experiment logging support for BrainTrust #49
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, the change looks pretty clean to me.
Is the idea that we'll "subscribe" to test emitter events and then send braintrust log statements as they occur?
We are in the middle of adding more granular profiling to BrainTrust btw, via an idea called "spans".
Not strictly necessary to include in the MVP, but if it's possible to emit an event each time a node executes for each test case, we can incrementally log span progress to BrainTrust, and then you'd be able to see performance metrics across the whole execution tree.
@@ -182,6 +186,21 @@ export function useLocalExecutor() { | |||
inputs, | |||
); | |||
}, | |||
// braintrustApiKey: settings.braintrustApiKey, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the WIP section?
@@ -0,0 +1,35 @@ | |||
// Extracted from braintrust library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these need to be extracted? Can they just be re-exported?
Ah yeah I can just pipe in the events from the graph execution! |
No description provided.