Multiple click crash handled #2
Conversation
|
Have you checked for missing onError in all places? |
|
I want to send another pull request with updates handling different error. Do I need to wait before this pull request gets accepted? Or can I send multiple pull requests at once? |
|
Yes, in the Notification Crash Handled commit, I added onError in all places except in the quiz one. I might still have missed adding the code in some places as the source code has lot of files. Do tell me if you find any. |
You can send multiple pull requests. That is not an issue. Just make sure to create a new branch for every pull request. |
|
@ayush-suman also please make sure that you request at least one of our name in the Reviewers section, and also assign every pull request to the proper person. |
|
Stash all the commits into one |
|
Updated the pull request commits with requested change implemented. |
|
@ayush-suman also your commit message should be Correct code indentation instead of Corrected code Indentation |
| } catch (e: ActivityNotFoundException) { | ||
| Toast.makeText( | ||
| applicationContext, | ||
| "Error. Not supported in your phone", | ||
| Toast.LENGTH_SHORT | ||
| ).show() |
There was a problem hiding this comment.
This is the correct indentaion for a Toast message, but because of the theme already followed throughout the app, make it in a single line. Try to keep your indentation uniform with the rest of the app
| Log.e("Main Activity", "Failed to recive token") | ||
| setupNotificationChannel() | ||
| } | ||
| } catch (e: Exception) { |
There was a problem hiding this comment.
make it } catch (e: Exception) { }
| if (appUpdateInfo.availableVersionCode().toString() == versionNumber && appUpdateInfo.isUpdateTypeAllowed( | ||
| AppUpdateType.IMMEDIATE | ||
| ) | ||
| ) { |
There was a problem hiding this comment.
Again, try following the indentation followed throughout the codebase
| val snackbar = Snackbar.make( | ||
| this.coordinator_parent, | ||
| "A newer version of the app is available", | ||
| Snackbar.LENGTH_INDEFINITE | ||
| ) | ||
| snackbar.setAction("UPDATE", object : View.OnClickListener { |
| data = | ||
| Uri.parse("https://play.google.com/store/apps/details?id=v2015.oasis.pilani.bits.com.home") |
There was a problem hiding this comment.
Make this in a single line
| val snackbar = Snackbar.make( | ||
| coordinator_parent, | ||
| "A new update has been downloaded and is ready to install", | ||
| Snackbar.LENGTH_INDEFINITE | ||
| ) | ||
| snackbar.setBehavior(object : BaseTransientBottomBar.Behavior() { |
There was a problem hiding this comment.
Solve this throughout your PR
| if (orderItems[position].status == 2){ | ||
| listener.updateOtpSeen(orderItems[position].orderId) | ||
| Log.d("OTP", "Called") | ||
| } | ||
| else{ | ||
| Log.d("OTP", "Status not yet ready ${orderItems[position].status}") | ||
| } | ||
| } | ||
| },{}) |
There was a problem hiding this comment.
Add a space after the comma, and one between the empty braces
| listener.addButtonClicked(stallItems[position], stallItems[position].quantity + 1) | ||
| } | ||
| },{}) |
|
@ayush-suman you also didn't change the Assignees section appropriately |
Handled the crash due to multiple clicks on RecyclerView of EventFragment.
Added onError in subscribe to in EventAdapter.