Refactor javascript, make geoJson include a pid #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #60
The geoJson implementation did not include a pid to allow us to open the popup window. I have refactored the code to include it as a property of the feature.
I have NOT tested this will a hook implementation bringing in outside geoJson. That could break the callback. Best case scenario, you get a map but clicking the markers doesn't open a popup. Worst case scenario, you don't get a map at all
I also refactored the Javascript into a core abstract class
IslandoraSimpleMap
and then extended that class for Google (IslandoraGoogleSimpleMap
) and OpenStreet Maps (IslandoraOSMSimpleMap
).This means each implementation only needs to overwrite the functions to do things in their way. The core initialization and decision making tree is common to both.
It does mean a lot more little functions, but a lot less duplicated javascript.