Islandora Sync: Fixes / Enhancements #23
Conversation
|
@slangerx might want to check your gitconfig settings. Your commits are showing up as authored by Also, I'm putting this on the agenda for the September 10 committes call. If you can attend, and speak to it, it would be great. Basically, we need to sort out how to test and merge any work done on Islandora Sync. tags @manez |
|
@ruebot Thanks! Yes, I just noticed that as well. Those commits came from a different environment -- obviously, one that I set up rather hurriedly. ;-) |
|
@slangerx you got that right 😄 |
|
Cool! Please list your Skype name or add me m.manez and I'll bring you in to the Committers Call. |
|
@whikloj FYI: I'm going to be off the grid until September 28th. Feel free to post any questions or comments here. Just know that I won't be able to respond for about two weeks. :-) |
|
Absolutely, have fun and I'll start digging. Great work. |
slangerx
changed the title
| $node_path = "public://$subdirectory"; | ||
| if (strtolower($field_info->dsid) != $extension) { | ||
| $file_name_component = '-' . str_replace($extension, '', strtolower($field_info->dsid)); | ||
| } |
There was a problem hiding this comment.
@slangerx, I'm not clear why this is needed, but if it is why does it only appears when there is a file_directory defined. Should it not appear below in the else as well?
There was a problem hiding this comment.
@whikloj Sorry about the delayed response -- and for lines 245-247. That code pertains to something unique to my organization's environment and shouldn't be in here. I'll make the appropriate changes within the hour. Good catch! -- and sorry about the confusion.
We use a customized version of Islandora Sync on our production site, Worthington Memory. This pull request includes most of the modifications we made along the way. The remaining changes are too specific to our particular setup and/or too weird to be generalized for other environments.
Changes in this pull request include:
Note that this pull request only impacts the Fedora-to-Drupal import process. Islandora Sync can also do the reverse (import Drupal content into Fedora) -- but no changes have been made to that.