Merge pull request #14 from gmoivan/develop

Agrega funcion get_target_max
IslasGECI · Feb 6, 2025 · d3e7fcd · d3e7fcd
2 parents ed4e475 + ada42fd
commit d3e7fcd
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/pollos_petrel/dummy_model.py b/pollos_petrel/dummy_model.py
@@ -14,6 +14,12 @@ def get_target_mean(dataset: pd.DataFrame) -> float:
     return mean_target
 
 
+# O)bten el maximo de target
+def get_target_max(dataset: pd.DataFrame) -> float:
+    max_target = dataset["target"].max()
+    return max_target
+
+
 # Lee test.csv
 def read_testing_dataset() -> pd.DataFrame:
     testing_dataset_path = "/workdir/data/raw/test.csv"

diff --git a/tests/test_dummy_model.py b/tests/test_dummy_model.py
@@ -2,6 +2,7 @@
     add_mean_as_target,
     drop_all_but_id,
     get_target_mean,
+    get_target_max,
     read_testing_dataset,
     read_training_dataset,
     write_submission,
@@ -27,6 +28,15 @@ def test_get_target_mean():
     assert expected_mean == obtained_mean
 
 
+# Obten el maximo de target
+def test_get_target_max():
+    data = {"id": [1, 2], "target": [3, 4]}
+    dataset = pd.DataFrame(data=data)
+    obtained_max = get_target_max(dataset)
+    expected_max = 4
+    assert expected_max == obtained_max
+
+
 # Lee test.csv
 def test_read_testing_dataset():
     testing_dataset = read_testing_dataset()