fix(Intune): correctly iterate when ssoInTuneAuthUser is provided #1502
Conversation
We need to iterate the values, not the indexes. closes: IsmaelMartinez#1466
|
|
Thanks a lot for contributing! I will create a pre-release and see if people can have a play with it. 1.2.1 has an annoying screensharing issue for some people, if we see this also happens to you I can try to do a 1.11.6 release with your changes. Thanks again for the fix! |
Could be a similar recent screen sharing issue like this one (specifically only present on MS Edge): https://learn.microsoft.com/en-au/answers/questions/2120532/screen-sharing-stops-working-(ms-teams-google-meet So I guess, the issue is caused by changes on MS side. Either in the Teams PWA or in how it's rendered in Edge. News is for me, that the Electron rendering teams-for-linux is using seems also affected. This info could help in identifying the regression location. Not sure where to address this, though. |
|
Might be unrelated as electron uses chromium on the back. I don't remember
if Edge is a chromium based browser or not, I think so, but with a lot of
MS tweaks?!? thanks for sharing and checking.
…On Fri, 29 Nov 2024, 08:39 Nils Ballmann, ***@***.***> wrote:
1.2.1 has an annoying screensharing issue for some people, if we see this
also happens to you I can try to do a 1.11.6 release with your changes.
Could be a similar recent screen sharing issue like this one (specifically
only present on MS Edge):
https://learn.microsoft.com/en-au/answers/questions/2120532/screen-sharing-stops-working-(ms-teams-google-meet
So I guess, the issue is caused by changes on MS side. Either in the Teams
PWA or in how it's rendered in Edge. News is for me, that the Electron
rendering teams-for-linux is using seems also affected. This info could
help in identifying the regression location. Not sure where to address
this, though.
—
Reply to this email directly, view it on GitHub
<#1502 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJHEHP26W225ZVRXGYO6T2DAR5LAVCNFSM6AAAAABSU6EXS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBXGMZDQOBWGY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.12.2 is pre release ready. |
MS Edge is definitely Chromium based. So it might be a regression of the Teams PWA even with all Chromium based software? The time based coincidence is just striking. |
|
It does seem to be a chromium issue #1489 (comment) but the fix is in version 131, what probably means we need to wait until electron 34 is out of beta (and a bit stable) and hopefully they will have the fix there :/ |
We need to iterate the values, not the indexes.
closes: #1466