This repository has been archived by the owner on Oct 16, 2019. It is now read-only.
№22 #13
Open
№22 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wronglink
reviewed
Jun 23, 2018
There was a problem hiding this comment.
Из-за переименования файла с тестами homework/tests.py → homework/№22, теперь они не запустятся (об этом сообщает pytest https://travis-ci.org/ItPeoplePython2018/lesson-1/builds/395512839)
| return 0 | ||
|
|
||
| def __init__(self, p1, p2): | ||
| pass |
There was a problem hiding this comment.
pass больше не нужен - у нас уже появился код для метода __init__
| pass | ||
| def translate(fraze, dic): | ||
| i = fraze.split() | ||
| Num = len(i) |
There was a problem hiding this comment.
Num,Tran,Translate- не python-стиль. Стоит переименовать вnum, т.к.CamelCaseзакреплен за именами классов.- Не обязательно итерироваться по индексам элементов в списке, можно сразу по этим элементам итерироваться:
split_fraze = fraze.split()
for word in split_fraze:
tran.append(dic[word])| @@ -93,7 +105,7 @@ def test_is_prime(): | |||
| """ | |||
|
|
|||
| def is_prime(n): | |||
| pass | |||
|
|
|||
There was a problem hiding this comment.
Без тела функции будет синтаксическая ошибка. Нужно либо pass вернуть, либо добавить код для фукнции.
| @@ -72,7 +77,14 @@ def test_translate(): | |||
| Документация по этому методу: https://docs.python.org/3/library/stdtypes.html#str.join | |||
| """ | |||
| def translate(fraze, dictionary): | |||
| pass | |||
| def translate(fraze, dic): | |||
There was a problem hiding this comment.
Второе объявление функции не нужно (речь о внутренней def translate(fraze, dic):)
def translate(fraze, dictionary):
def translate(fraze, dic):
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.