This repository has been archived by the owner on Oct 16, 2019. It is now read-only.
firsf task #5
Open
firsf task #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
добавила import math для третьего задания
переместила импорт
=D бывает
wronglink
reviewed
Jun 19, 2018
homework/tests.py
Outdated
| @@ -16,7 +22,9 @@ def test_increment_decorator(): | |||
| декрорируемую функцию. | |||
| """ | |||
| def increment_derocator(func): | |||
| pass | |||
| def decor(val): | |||
| return func(val)+1 | |||
There was a problem hiding this comment.
+ 1 нужно внутри функции - т.е. не к результату функции, а к аргументу.
Также в python принято операторы обрамлять + с каждой из сторон: func(val) + 1
homework/tests.py
Outdated
| def test_even_fucntion(): | ||
| """ | ||
| Необходимо реализовать функцию even_filter, которая получает неограниченное количество аргументов | ||
| и возвращает из них только четные. | ||
| """ | ||
|
|
||
| def even_filter(*args): | ||
| pass | ||
| res = [] | ||
| for count in args: |
There was a problem hiding this comment.
Итератор будет идти не по индексам списка, а по значениям. Т.е. тут не for count in args, а for arg in args.
Если там окажутся не idx + 1, как в тесте, а [1, 9, 3, 4, 5, 2, 10], то код сломается.
|
Поправила в соответствии с комментариями |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.