This repository has been archived by the owner on Oct 16, 2019. It is now read-only.
Hometask for lesson 6 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {% extends 'base.html' %} | ||
|
|
||
| {% block content %} | ||
| {% load static %} |
There was a problem hiding this comment.
{% load static %} лучше переместить наверх, сразу после extends. Такая конструкция сейчас валидна но если с этим кодом будут работать другие разработчики они могут не заметить что где то внутри уже был загружен модуль для работы статикой
templates/base.html
Outdated
| <html> | ||
| <head> | ||
| <title>Книжный магазин</title> | ||
| {% load static %} |
main/templates/main/index.html
Outdated
| <div class="book-preview__name">{{ book.name }}</div> | ||
| <div class="spring"></div> | ||
| <div class="book-preview__author">{{ book.author }}</div> | ||
| <a href="/catalog/{{ book.id }}">Подробнее</a> |
There was a problem hiding this comment.
На лекции я упустил. Есть шаблонный тег {% url ... %}, который решает эту проблем
main/templates/main/index.html
Outdated
| <div> | ||
| <div class="main"> | ||
| <div class="main__book"> | ||
|
|
||
| {% load static %} |
There was a problem hiding this comment.
Тоже самое что описал сверху
| @@ -2,6 +2,7 @@ | |||
| from django.shortcuts import render | |||
| from catalog.data import BOOKS | |||
|
|
|||
|
|
|||
| <div class="main__book"> | ||
| <div class="book-detail"> | ||
| <div class="book-detail__cover book-detail-cover"> | ||
| <img class="book-detail-cover__img" src="{% static "" %}/{{ book.cover }}" alt="Название книги" > |
There was a problem hiding this comment.
{% static "" %}/{{ book.cover }} -> {% static book.cover %}
…tatic img references corrected and {% url %} is used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.