[MOB-6878] iOS IterableEmbeddedView (OOTB) #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed these errors in the subsequent url/action handlers PR. |
Base automatically changed from
anelson/6734-update-messages-with-placements
to
embedded-messaging
December 13, 2023 20:37
Config object Enum for type Removal of ViewDelegate and its methods
1. Clicks now call the action handler and urlHandler of iterableConfig. This means they can open passed url. However, in recent commit, Ive removed the generic delegate methods which removes the didPrimaryButtonPressed and similar callbacks that viewControllers could implement. Now this is more aligned with Android implementation. 2. Sync messages now gets called in manager's init method. We have to try accomplishing the same thing via app's lifecycle activity. Somehow, for the first launch, the manager is not calling sync messages. Hence calling it during initialization
…roid [MOB-7458] - Aligning iOS with Android
[MOB-7475] updates button naming to primary and secondary
…-view-type [MOB-7474] updates configuration to properly use default values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s)
✏️ Description
This PR implements the IterableEmbeddedView, which is an out of the box view for embedded messaging. The SDK implementation can be used with the corresponding Fiterable OOTB PR to see how the IterableEmbeddedView is used in a client app.
Merging into anelson/6734-update-messages-with-placements which is currently awaiting PR into
embedded-messagingbranch.