[MOB-7458] - Aligning iOS with Android #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config object Enum for type Removal of ViewDelegate and its methods
Ayyanchira
changed the base branch from
anelson/ootb-banner
to
embedded-messaging
1. Clicks now call the action handler and urlHandler of iterableConfig. This means they can open passed url. However, in recent commit, Ive removed the generic delegate methods which removes the didPrimaryButtonPressed and similar callbacks that viewControllers could implement. Now this is more aligned with Android implementation. 2. Sync messages now gets called in manager's init method. We have to try accomplishing the same thing via app's lifecycle activity. Somehow, for the first launch, the manager is not calling sync messages. Hence calling it during initialization
evantk91
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
LGTM at least for today's bug bash.
A few points we need to address before release:
- notification default is not aligned with Android. The background and border colors differ from the card and banner styles.
- the second button is defaulting to this weird block button. it should be a button with a transparent background and the same color text as the first button. See the figma.
- the second button background and border color should be configurable. I will add this to the android side.
- the card view type should collapse when the image is not provided to align with the android side and the discussion I had with design (stephanie)
|
|
||
| public init(backgroundColor: UIColor? = UIColor.white, | ||
| borderColor: UIColor? = UIColor.white, | ||
| borderWidth: CGFloat? = 0, |
There was a problem hiding this comment.
Looks good. But the notification view has different characteristics.
| } | ||
| } | ||
|
|
||
| //TODO: Remove commented lines before release |
|
Will bug bash with this branch so we can work on this before merging into embedded |
evantk91
changed the base branch from
embedded-messaging
to
anelson/ootb-banner
|
evantk91
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s)
✏️ Description
Config object
Enum for type
Removal of ViewDelegate and its methods