[MOB-10951] Add mobile framework info to register token request #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumeruchat
changed the title
sumeruchat
changed the title
sumeruchat
changed the title
joaodordio
reviewed
Jan 15, 2025
davidtruong
reviewed
Jan 15, 2025
| let hasFlutter = hasFrameworkClasses(FrameworkClasses.flutter) | ||
| let hasReactNative = hasFrameworkClasses(FrameworkClasses.reactNative) | ||
|
|
||
| switch (hasFlutter, hasReactNative) { |
There was a problem hiding this comment.
We could probably refactor this later in the case where we have more than 2 frameworks.
joaodordio
approved these changes
Jan 16, 2025
bradumbaugh
reviewed
Jan 24, 2025
Comment on lines
+14
to
+15
| let frameworkType: IterableAPIMobileFrameworkType | ||
| let iterableSdkVersion: String? |
There was a problem hiding this comment.
@sumeruchat I think maybe we need to mark these as public, so they're accessible in outside modules that rely on this struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s)
✏️ Description
Add mobile framework info to iOS according to spec
Please read the full spec at https://iterable.slab.com/posts/mobile-datadog-dashboard-flutter-rn-support-fd6p2n7e?shr=6m4blt3qaTsWYn38av0w-Mkg