Challenge redislabs-training#7

Rate limiter Implement `hit()` in `RateLimiterSlidingDaoRedisImpl.java`.
J-A-I-L · Jul 11, 2022 · 09f7064 · 09f7064
1 parent aaf1fb0
commit 09f7064
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 4 deletions.
diff --git a/src/main/java/com/redislabs/university/RU102J/dao/RateLimiterSlidingDaoRedisImpl.java b/src/main/java/com/redislabs/university/RU102J/dao/RateLimiterSlidingDaoRedisImpl.java
@@ -1,6 +1,9 @@
 package com.redislabs.university.RU102J.dao;
 
-import redis.clients.jedis.JedisPool;
+import com.redislabs.university.RU102J.core.KeyHelper;
+import redis.clients.jedis.*;
+
+import java.util.UUID;
 
 public class RateLimiterSlidingDaoRedisImpl implements RateLimiter {
 
@@ -19,6 +22,23 @@ public RateLimiterSlidingDaoRedisImpl(JedisPool pool, long windowSizeMS,
     @Override
     public void hit(String name) throws RateLimitExceededException {
         // START CHALLENGE #7
+        try (Jedis jedis = jedisPool.getResource()) {
+            String keyName = "limiter" + ":" + windowSizeMS + ":" + name + ":" + maxHits;
+            String key = KeyHelper.getKey(keyName);
+
+            final Transaction transaction = jedis.multi();
+            final long currentTimeStamp = System.currentTimeMillis();
+            final UUID uuid = UUID.randomUUID();
+            final String member = "" + currentTimeStamp + "-" + uuid;
+            transaction.zadd(key, currentTimeStamp, member);
+            transaction.zremrangeByScore(key,0,  currentTimeStamp - windowSizeMS);
+            final Response<Long> hits = transaction.zcard(key);
+            transaction.exec();
+
+            if (hits.get() > maxHits) {
+                throw new RateLimitExceededException();
+            }
+        }
         // END CHALLENGE #7
     }
 }
diff --git a/src/test/java/com/redislabs/university/RU102J/dao/RateLimiterSlidingDaoRedisImplTest.java b/src/test/java/com/redislabs/university/RU102J/dao/RateLimiterSlidingDaoRedisImplTest.java
@@ -47,7 +47,6 @@ public void flush() {
         keyManager.deleteKeys(jedis);
     }
 
-    @Ignore
     @Test
     public void hit() {
         int exceptionCount = 0;
@@ -64,7 +63,6 @@ public void hit() {
         assertThat(exceptionCount, is(0));
     }
 
-    @Ignore
     @Test
     public void hitOutsideLimit() {
         int exceptionCount = 0;
@@ -81,7 +79,6 @@ public void hitOutsideLimit() {
         assertThat(exceptionCount, is(2));
     }
 
-    @Ignore
     @Test
     public void hitOutsideWindow() throws InterruptedException {
         int exceptionCount = 0;