Allow to set up custom ban duration via CAPTCHABOT_BAN_DURATION option #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Rios
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this feature is needed by the community, but in our chat, we decided to give users temporary bans to prevent them from instantly rejoining (we use this bot as a soft power tool, just to let users know they've chosen the wrong chat).
I found that
tlgbotutils.tlg_ban_useralready has a parameter for ban duration, so I added a configuration option to specify it. By default, it's set to-1, which means an indefinite ban, so backward compatibility is maintained.Important: I didn’t change the localization texts for the ban to avoid overcomplicating the logic, so the ban message still says that a chat admin needs to manually unban the user.