Add a few new metadata variables in tempo for QC and BC #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -278,6 +296,9 @@ def _read(self): | |||
| self.outdata[('longitude', 'MetaData')] = lons[flg] | |||
| self.outdata[('quality_assurance_value', 'MetaData')] = qa_value[flg] | |||
| self.outdata[('cloud_fraction', 'MetaData')] = cld_fra[flg] | |||
| self.outdata[('solar_zenith_angle', 'MetaData')] = sza[flg] | |||
There was a problem hiding this comment.
are these the right IODA names? I thought snake case was frowned upon?
There was a problem hiding this comment.
thanks @CoryMartin-NOAA ,, you are correct the name to use is:
solarZenithAngle
note the first name in the list is the current standard with the other names ones that would be changed into the leading entry if the upgrader were run something like:
${JEDI_BUILD}/bin/ioda-upgrade-v2-to-v3.x ${ioda_v2} ${ioda_v3} ${JEDI_SRC}/ioda/share/ioda/yaml/validation/ObsSpace.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a few new metadata variables in tempo for QC and BC.
Issue(s) addressed
Resolves #<issue_number>
Dependencies
List the other PRs that this PR is dependent on:
Impact
Expected impact on downstream repositories:
Checklist