Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jedi repos (fv3-jedi, soca) from develop 2023/12/12 #47

Merged
merged 5 commits into from
Dec 18, 2023

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Dec 12, 2023

Description

Temporarily change names of fv3-jedi and soca branches for update from develop. The fv3-jedi update PR was already merged, once JCSDA-internal/soca#987 is merged I will revert the soca branch name and the only "updates" in this PR will be the dates in the comments (last updated xx/yy/zzzz).

Issue(s) addressed

Part of ALGO-61 epic

Dependencies

Impact

n/a

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@climbfuji climbfuji added the INFRA JEDI Infrastructure label Dec 12, 2023
@climbfuji climbfuji self-assigned this Dec 12, 2023
@climbfuji climbfuji marked this pull request as ready for review December 15, 2023 04:11
@climbfuji climbfuji added ALGO JEDI Algorithms SOCA Sea-ice, Ocean, and Coupled Assimilation labels Dec 15, 2023
mark-a-potts
mark-a-potts previously approved these changes Dec 15, 2023
@climbfuji
Copy link
Collaborator Author

climbfuji commented Dec 18, 2023

This was approved previously, pushing the reversal of the soca branch name dismissed the review. CI tests passed, so after another self-review I'll go ahead and merge.

Self-review: add back in the various UPDATE statements and push to the correct (old) ufs-weather-model branch, then check again.

@climbfuji climbfuji merged commit 05fd0a2 into develop Dec 18, 2023
1 check passed
@climbfuji climbfuji deleted the feature/update_jedi_from_dev_20231212 branch December 18, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO JEDI Algorithms INFRA JEDI Infrastructure SOCA Sea-ice, Ocean, and Coupled Assimilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants