Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use develop branch of fv3-jedi-linearmodel; update README.md to use [email protected] #51

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Feb 8, 2024

Description

  1. Update CMakeLists.txt: switch to fv3-jedi-linearmodel develop, add missing UPDATE to fv3-jedi-data; remove trailing whitespaces.
  2. Update README.md to use spack-stack-1.5.1. Note that the second half of README.md still needs updating. I will do that once I fixed the UFS ctests on macOS (they are failing right now).

Issue(s) addressed

Resolves CI failures: https://github.com/JCSDA/ufs-bundle/actions/runs/7824689789/job/21347651794
Resolves #50

Dependencies

n/a

Impact

n/a

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@climbfuji climbfuji self-assigned this Feb 8, 2024
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Feb 8, 2024
@climbfuji climbfuji marked this pull request as ready for review February 8, 2024 19:59
Copy link
Collaborator

@mark-a-potts mark-a-potts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@shlyaeva shlyaeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test, looks good to me (and hooray to even fewer custom branches!)

@climbfuji climbfuji merged commit f7c5e1a into develop Feb 8, 2024
1 check passed
@climbfuji climbfuji deleted the feature/fv3-jedi-lm_develop branch February 8, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fv3-jedi-data needs UPDATE attribute
3 participants