Set FV3_PRECISION to DOUBLE in CMakeLists.txt #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
force-pushed
the
bugfix/set_fv3_precision
branch
from
c597050 to
1ff15ee
Compare
climbfuji
requested review from
mark-a-potts,
ashley314,
cmgas and
shlyaeva
and removed request for
ashley314
shlyaeva
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All in the title. I think we should set this explicitly and not rely on our luck that the precision used for the ufs-weather-model matches the default in fv3-jedi.
Todo:
Issue(s) addressed
In preparation for https://github.com/JCSDA-internal/fv3-jedi/issues/1188
Dependencies
Impact
n/a
Checklist