Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Tooltips to work with new RED.popover.tooltip API #1

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

jpwsutton
Copy link

Hi @JonSilver, I saw your PR in the main repo (node-red#67) and went ahead and fixed the tooltips so that they work with Node-RED 1.0 for you, so you should be able to push it now.

I did do get an error in the console though that I was hoping you might understand better than I:

Uncaught TypeError: Cannot read property 'type' of undefined
    at Object.<anonymous> (client.js:59)
    at Object.10 (helpers.js:15)
    at Object.f [as inverse] (handlebars-2.0.0.js:27)
    at Object.<anonymous> (handlebars-2.0.0.js:27)
    at Object.9 (helpers.js:10)
    at Object.f [as inverse] (handlebars-2.0.0.js:27)
    at Object.<anonymous> (handlebars-2.0.0.js:27)
    at Object.main (helpers.js:26)
    at e (handlebars-2.0.0.js:27)
    at s.render (index.js:24)

Signed-off-by: James Sutton [email protected]

@JonSilver
Copy link

Thanks very much, @jpwsutton - I'll take a look. Does Nick O'Leary yet know you've been working on this?

It looks like that console error is due to an object passed into client.js being undefined, though the execution stack isn't clear. client.js isn't one of ours - I think it belongs to swagger-ui. But it definitely receives data from our code. So I'll take a look at that too.

@JonSilver JonSilver self-assigned this Nov 12, 2019
@JonSilver JonSilver added the bug Something isn't working label Nov 12, 2019
@jpwsutton
Copy link
Author

Thanks @JonSilver, yes both Nick and DCJ are aware so should be expecting the change.

@JonSilver JonSilver merged commit c457c32 into JFDI-Consulting:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants