Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing pyang "uses" expansion handling #35

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Conversation

BrianSipos
Copy link
Member

@BrianSipos BrianSipos commented Dec 23, 2024

There was inconsistent use of pyang Statement.search_one() and Statement.search() which was producing duplicate subordinate statements in cases where a grouping was used containing object-subordinate keywords like amm:parameter or amm:operand. This update makes explicit use use the search "children" parameter to determine whether to look in direct children only (the default) or include uses-copied substatements.

This also fixes an issue that the ARI text encoder wasn't properly handling dict parameter type.

@BrianSipos BrianSipos self-assigned this Dec 23, 2024
@BrianSipos BrianSipos added this to the ACE v2.0.0 milestone Dec 23, 2024
@justinethier
Copy link

@BrianSipos In addition to the review comments it's a bit unclear exactly why these changes were made. It might help to add more information to the PR. Also, do we need to add any additional tests for these changes?

@BrianSipos BrianSipos changed the title Fixing pyang uses expansion handling Fixing pyang "uses" expansion handling Jan 10, 2025
Copy link

@justinethier justinethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue but otherwise is good to go.

@BrianSipos BrianSipos merged commit b5b2007 into apl-fy24 Jan 10, 2025
10 checks passed
@BrianSipos BrianSipos deleted the pyang-plugin-updates branch January 10, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants