forked from NASA-AMMOS/anms-ace
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing pyang "uses" expansion handling #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinethier
reviewed
Jan 2, 2025
justinethier
reviewed
Jan 2, 2025
justinethier
reviewed
Jan 2, 2025
@BrianSipos In addition to the review comments it's a bit unclear exactly why these changes were made. It might help to add more information to the PR. Also, do we need to add any additional tests for these changes? |
…t was ignoring grouping-uses substatements.
justinethier
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor issue but otherwise is good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was inconsistent use of pyang
Statement.search_one()
andStatement.search()
which was producing duplicate subordinate statements in cases where a grouping was used containing object-subordinate keywords likeamm:parameter
oramm:operand
. This update makes explicit use use the search "children" parameter to determine whether to look in direct children only (the default) or includeuses
-copied substatements.This also fixes an issue that the ARI text encoder wasn't properly handling
dict
parameter type.