Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get SQL generation agreeing with schema from dtnma-tools #29

Merged
merged 6 commits into from
Mar 10, 2025
Merged

Get SQL generation agreeing with schema from dtnma-tools #29

merged 6 commits into from
Mar 10, 2025

Conversation

BrianSipos
Copy link
Member

This will have failing CI until the generated SQL executes within the target schema.

@BrianSipos BrianSipos added this to the CAMP v3.0.0 milestone Mar 6, 2025
@d-linko d-linko marked this pull request as ready for review March 7, 2025 23:35
@d-linko d-linko self-assigned this Mar 7, 2025
BrianSipos
BrianSipos commented Mar 10, 2025
View reviewed changes
Copy link
Member Author

@BrianSipos BrianSipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments about simplifying and string-safeing the template, not about its output though.

BrianSipos
BrianSipos commented Mar 10, 2025
View reviewed changes
Copy link
Member Author

@BrianSipos BrianSipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot approve this through the UI but consider this my approval.
I appreciate using the feedback to simplify the template and hopefully avoid SQL text errors or inconsistencies.

@BrianSipos BrianSipos linked an issue Mar 10, 2025 that may be closed by this pull request
Update CAMP to produce valid SQL-for-ANMS output files #5
Closed
@d-linko d-linko merged commit d512269 into apl-fy24 Mar 10, 2025
12 checks passed
@d-linko d-linko deleted the fix-sql-ci branch March 10, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-linko d-linko d-linko approved these changes

Assignees

@d-linko d-linko

Labels
None yet
Projects
None yet
Milestone
CAMP v3.0.0
Development

Successfully merging this pull request may close these issues.

Update CAMP to produce valid SQL-for-ANMS output files
2 participants
@BrianSipos @d-linko