Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config for ESM compatibility #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hmenzagh
Copy link
Contributor

Simple PR to add a config.esm property to load models on the .default in the case that ESM is used

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #253 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   81.49%   81.51%   +0.01%     
==========================================
  Files          24       24              
  Lines        2804     2807       +3     
==========================================
+ Hits         2285     2288       +3     
  Misses        519      519              
Impacted Files Coverage Δ
config.js 100.00% <100.00%> (ø)
rest-hapi.js 90.81% <100.00%> (ø)
utilities/joi-mongoose-helper.js 89.20% <100.00%> (ø)
utilities/model-generator.js 82.00% <100.00%> (+0.36%) ⬆️
utilities/rest-helper-factory.js 80.39% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff05901...e6bb071. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant