Skip to content

Commit

Permalink
Remove debugging ret parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
JMGaljaard committed Sep 26, 2022
1 parent c616d45 commit a563aeb
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions fltk/core/distributed/orchestrator.py
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def _create_config_maps(self, config_maps: Dict[str, V1ConfigMap]) -> None:
self._v1.create_namespaced_config_map(self._config.cluster_config.namespace,
config_map)

def wait_for_jobs_to_complete(self, ret=False, others: Optional[List[str]] = None):
def wait_for_jobs_to_complete(self, others: Optional[List[str]] = None):
"""
Function to wait for all tasks to complete. This allows to wait for all the resources to free-up after running
an experiment. Thereby allowing for running multiple experiments on a single cluster, without letting
Expand Down Expand Up @@ -322,7 +322,7 @@ def run(self, clear: bool = False,
if wait_historical:
curr_jobs = self._client.get(namespace="test")
jobs = [job['metadata']['name'] for job in curr_jobs['items']]
self.wait_for_jobs_to_complete(ret=False, others=jobs)
self.wait_for_jobs_to_complete(others=jobs)
start_time = time.time()

if clear:
Expand Down Expand Up @@ -365,9 +365,9 @@ def run(self, clear: bool = False,
# Either wait to complete, or continue. Note that the orchestrator currently does not support scaling
# experiments up or down.
if not self._config.cluster_config.orchestrator.parallel_execution:
self.wait_for_jobs_to_complete(ret=True)
self.wait_for_jobs_to_complete()
if self._config.cluster_config.orchestrator.parallel_execution:
self.wait_for_jobs_to_complete(ret=False)
self.wait_for_jobs_to_complete()
logging.info('Experiment completed.')
# Stop experiment
self.stop()

0 comments on commit a563aeb

Please sign in to comment.