Skip to content

Commit

Permalink
Update implementation
Browse files Browse the repository at this point in the history
  • Loading branch information
JMGaljaard committed Sep 4, 2022
1 parent 1eaa73e commit ddd9c4d
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 83 deletions.
9 changes: 7 additions & 2 deletions fltk/core/distributed/orchestrator.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
def _generate_experiment_path_name(task: ArrivalTask, u_id: str, config: DistributedConfig):
"""
Helper function to generate experiment name for logging without conflicts
@param task: Arrival task for Task realted information.
@param task: Arrival task for Task related information.
@type task: ArrivalTask
@param u_id: Unique identifier string corresponding to the experiment.
@type u_id: str
Expand Down Expand Up @@ -221,7 +221,8 @@ def run_batch(self, clear: bool = False) -> None:

def __clear_jobs(self):
"""
Function to clear existing jobs in the environment (i.e. old experiments/tests)
Function to clear existing jobs in the environment (i.e. old experiments/tests). This will will, currently,
not remove configuration map objects. A later version will allow for removing these autmatically as well.
@return: None
@rtype: None
"""
Expand All @@ -242,6 +243,10 @@ def __clear_jobs(self):
self.__logger.warning(f'Could not delete: {job_name}. Reason: {excp}')

def __create_config_maps(self, config_maps: Dict[str, V1ConfigMap]):
"""
Private helper function to generate V1ConfigMap resources that are to be attached to the different trainers.
This allows for dynamic (at least more dynamic) deployment with regenerated configuration files.
"""
for _, config_map in config_maps.items():
self._v1.create_namespaced_config_map(self._config.cluster_config.namespace,
config_map)
81 changes: 0 additions & 81 deletions jupyter/terraform-gke/.terraform.lock.hcl

This file was deleted.

6 changes: 6 additions & 0 deletions jupyter/terraform-gke/providers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,9 @@ provider "google" {
access_token = data.google_service_account_access_token.default.access_token
request_timeout = "60s"
}

provider "google-beta" {
project = var.project_id
access_token = data.google_service_account_access_token.default.access_token
request_timeout = "60s"
}

0 comments on commit ddd9c4d

Please sign in to comment.