fix: return NULL when parsing empty Strings

- fixes #1963 Signed-off-by: Andreas Reichel <[email protected]>
JSQLParser · Feb 23, 2024 · 94fb872 · 94fb872
1 parent 17f5f2a
commit 94fb872
Show file tree

Hide file tree

Showing 2 changed files with 57 additions and 4 deletions.
diff --git a/src/main/java/net/sf/jsqlparser/parser/CCJSqlParserUtil.java b/src/main/java/net/sf/jsqlparser/parser/CCJSqlParserUtil.java
@@ -79,6 +79,10 @@ public static Statement parse(String sql) throws JSQLParserException {
     public static Statement parse(String sql, Consumer<CCJSqlParser> consumer)
             throws JSQLParserException {
 
+        if (sql == null || sql.isEmpty()) {
+            return null;
+        }
+
         ExecutorService executorService = Executors.newSingleThreadExecutor();
         Statement statement = null;
         try {
@@ -92,8 +96,11 @@ public static Statement parse(String sql, Consumer<CCJSqlParser> consumer)
     public static Statement parse(String sql, ExecutorService executorService,
             Consumer<CCJSqlParser> consumer)
             throws JSQLParserException {
-        Statement statement = null;
+        if (sql == null || sql.isEmpty()) {
+            return null;
+        }
 
+        Statement statement = null;
         // first, try to parse fast and simple
         CCJSqlParser parser = newParser(sql);
         if (consumer != null) {
@@ -122,6 +129,10 @@ public static Statement parse(String sql, ExecutorService executorService,
     }
 
     public static CCJSqlParser newParser(String sql) {
+        if (sql == null || sql.isEmpty()) {
+            return null;
+        }
+
         return new CCJSqlParser(new StringProvider(sql));
     }
 
@@ -134,6 +145,10 @@ public static CCJSqlParser newParser(InputStream is, String encoding) throws IOE
     }
 
     public static Node parseAST(String sql) throws JSQLParserException {
+        if (sql == null || sql.isEmpty()) {
+            return null;
+        }
+
         CCJSqlParser parser = newParser(sql);
         try {
             parser.Statement();
@@ -162,20 +177,31 @@ public static Statement parse(InputStream is, String encoding) throws JSQLParser
     }
 
     public static Expression parseExpression(String expression) throws JSQLParserException {
+        if (expression == null || expression.isEmpty()) {
+            return null;
+        }
+
         return parseExpression(expression, true);
     }
 
     public static Expression parseExpression(String expression, boolean allowPartialParse)
             throws JSQLParserException {
+        if (expression == null || expression.isEmpty()) {
+            return null;
+        }
+
         return parseExpression(expression, allowPartialParse, p -> {
         });
     }
 
     @SuppressWarnings("PMD.CyclomaticComplexity")
     public static Expression parseExpression(String expressionStr, boolean allowPartialParse,
             Consumer<CCJSqlParser> consumer) throws JSQLParserException {
-        Expression expression = null;
+        if (expressionStr == null || expressionStr.isEmpty()) {
+            return null;
+        }
 
+        Expression expression = null;
         // first, try to parse fast and simple
         try {
             CCJSqlParser parser = newParser(expressionStr).withAllowComplexParsing(false);
@@ -225,6 +251,9 @@ public static Expression parseExpression(String expressionStr, boolean allowPart
      * @see #parseCondExpression(String, boolean)
      */
     public static Expression parseCondExpression(String condExpr) throws JSQLParserException {
+        if (condExpr == null || condExpr.isEmpty()) {
+            return null;
+        }
         return parseCondExpression(condExpr, true);
     }
 
@@ -238,15 +267,21 @@ public static Expression parseCondExpression(String condExpr) throws JSQLParserE
      */
     public static Expression parseCondExpression(String condExpr, boolean allowPartialParse)
             throws JSQLParserException {
+        if (condExpr == null || condExpr.isEmpty()) {
+            return null;
+        }
         return parseCondExpression(condExpr, allowPartialParse, p -> {
         });
     }
 
     @SuppressWarnings("PMD.CyclomaticComplexity")
     public static Expression parseCondExpression(String conditionalExpressionStr,
             boolean allowPartialParse, Consumer<CCJSqlParser> consumer) throws JSQLParserException {
-        Expression expression = null;
+        if (conditionalExpressionStr == null || conditionalExpressionStr.isEmpty()) {
+            return null;
+        }
 
+        Expression expression = null;
         // first, try to parse fast and simple
         try {
             CCJSqlParser parser =
@@ -323,11 +358,19 @@ public Statement call() throws ParseException {
      * @return the statements parsed
      */
     public static Statements parseStatements(String sqls) throws JSQLParserException {
+        if (sqls == null || sqls.isEmpty()) {
+            return null;
+        }
+
         return parseStatements(sqls, null);
     }
 
     public static Statements parseStatements(String sqls, Consumer<CCJSqlParser> consumer)
             throws JSQLParserException {
+        if (sqls == null || sqls.isEmpty()) {
+            return null;
+        }
+
         ExecutorService executorService = Executors.newSingleThreadExecutor();
         final Statements statements = parseStatements(sqls, executorService, consumer);
         executorService.shutdown();
@@ -343,8 +386,11 @@ public static Statements parseStatements(String sqls, Consumer<CCJSqlParser> con
     public static Statements parseStatements(String sqls, ExecutorService executorService,
             Consumer<CCJSqlParser> consumer)
             throws JSQLParserException {
-        Statements statements = null;
+        if (sqls == null || sqls.isEmpty()) {
+            return null;
+        }
 
+        Statements statements = null;
         CCJSqlParser parser = newParser(sqls);
         if (consumer != null) {
             consumer.accept(parser);

diff --git a/src/test/java/net/sf/jsqlparser/parser/CCJSqlParserUtilTest.java b/src/test/java/net/sf/jsqlparser/parser/CCJSqlParserUtilTest.java
@@ -12,6 +12,7 @@
 import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
@@ -507,4 +508,10 @@ void testUnbalancedPosition() {
                 " from tab";
         assertEquals(1122, CCJSqlParserUtil.getUnbalancedPosition(sqlStr));
     }
+
+    @Test
+    void testParseEmpty() throws JSQLParserException {
+        assertNull(CCJSqlParserUtil.parse(""));
+        assertNull(CCJSqlParserUtil.parse((String) null));
+    }
 }