Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2119 add support INSERT OVERWRITE PARTITION #2135

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

tt20061904
Copy link
Contributor

support INSERT OVERWRITE PARTITION

@tt20061904 tt20061904 closed this Jan 2, 2025
@manticore-projects
Copy link
Contributor

Greetings! thank you for your contribution. Changes are needed though:

  1. please resolve the choice conflict in the grammar
 Warning: Choice conflict in [...] construct at line 1682, column 78.
         Expansion nested within construct and expansion following construct
         have common prefixes, one of which is: "TABLE"
         Consider using a lookahead of 2 or more for nested expansion.
  1. please update the keywords after as explained here: https://manticore-projects.com/JSQLParser/contribution.html#manage-reserved-keywords

@tt20061904 tt20061904 reopened this Jan 3, 2025
@tt20061904
Copy link
Contributor Author

@manticore-projects
Copy link
Contributor

Much better already, but Q/A still fails. Run './gradlew :spotlessApply' to fix these violations.
In general, run './gradlew :check' before pushing.

@manticore-projects manticore-projects merged commit f1dee4c into JSQLParser:master Jan 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants