forked from JabRef/jabref
-
Notifications
You must be signed in to change notification settings - Fork 15
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
…abRef#12038) * Caught an error when accessing an invalid path. fixes JabRef#10548 * Fixed typo in issue num * Moved changelog entry to unreleased section * Moved try-catch and added tests * Fix checkstyle * Fix checkstyle again * Fix checkstyle fr this time * Discard changes to external-libraries.md * Result of "rewriteRun" * Add link to issue * Use VisibleForTesting annotation * Remove Jimfs depdencency --------- Co-authored-by: Tom Martin <[email protected]> Co-authored-by: Oliver Kopp <[email protected]>
- Loading branch information
3 people
authored
Oct 23, 2024
1 parent
b90ef75
commit 60e9ded
Showing
3 changed files
with
126 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90 changes: 90 additions & 0 deletions
90
src/test/java/org/jabref/gui/importer/actions/OpenDatabaseActionTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| package org.jabref.gui.importer.actions; | ||
|
|
||
| import java.nio.file.Path; | ||
| import java.util.List; | ||
|
|
||
| import org.jabref.gui.ClipBoardManager; | ||
| import org.jabref.gui.DialogService; | ||
| import org.jabref.gui.LibraryTabContainer; | ||
| import org.jabref.gui.StateManager; | ||
| import org.jabref.gui.preferences.GuiPreferences; | ||
| import org.jabref.gui.undo.CountingUndoManager; | ||
| import org.jabref.gui.util.FileDialogConfiguration; | ||
| import org.jabref.logic.FilePreferences; | ||
| import org.jabref.logic.ai.AiService; | ||
| import org.jabref.logic.util.Directories; | ||
| import org.jabref.logic.util.TaskExecutor; | ||
| import org.jabref.model.entry.BibEntryTypesManager; | ||
| import org.jabref.model.util.FileUpdateMonitor; | ||
|
|
||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.io.TempDir; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; | ||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertThrows; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.spy; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| public class OpenDatabaseActionTest { | ||
| DialogService dialogService; | ||
| GuiPreferences guiPreferences; | ||
| OpenDatabaseAction openDatabaseAction; | ||
|
|
||
| @BeforeEach | ||
| void initializeOpenDatabaseAction() { | ||
| dialogService = mock(DialogService.class); | ||
| guiPreferences = mock(GuiPreferences.class); | ||
| openDatabaseAction = spy(new OpenDatabaseAction( | ||
| mock(LibraryTabContainer.class), | ||
| guiPreferences, | ||
| mock(AiService.class), | ||
| dialogService, | ||
| mock(StateManager.class), | ||
| mock(FileUpdateMonitor.class), | ||
| mock(BibEntryTypesManager.class), | ||
| mock(CountingUndoManager.class), | ||
| mock(ClipBoardManager.class), | ||
| mock(TaskExecutor.class) | ||
| )); | ||
| } | ||
|
|
||
| @Test | ||
| void getFilesToOpenFailsToOpenPath(@TempDir Path tempDir) { | ||
| Path path = tempDir.resolve("test-dir"); | ||
|
|
||
| FilePreferences filePreferences = mock(FilePreferences.class); | ||
| FileDialogConfiguration badConfig = mock(FileDialogConfiguration.class); | ||
| FileDialogConfiguration goodConfig = mock(FileDialogConfiguration.class); | ||
|
|
||
| when(guiPreferences.getFilePreferences()).thenReturn(filePreferences); | ||
| when(openDatabaseAction.getInitialDirectory()).thenReturn(path); | ||
|
|
||
| // Make it so that showFileOpenDialogAndGetMultipleFiles will throw an error when called with the bad path, but | ||
| // not for the good path as in issue #10548 | ||
| when(dialogService.showFileOpenDialogAndGetMultipleFiles(badConfig)) | ||
| .thenAnswer(x -> { | ||
| throw new IllegalArgumentException(); | ||
| }); | ||
| when(dialogService.showFileOpenDialogAndGetMultipleFiles(goodConfig)) | ||
| .thenAnswer(x -> List.of()); | ||
|
|
||
| // Simulate a scenario where the initial directory is good | ||
| when(openDatabaseAction.getFileDialogConfiguration(openDatabaseAction.getInitialDirectory())) | ||
| .thenReturn(goodConfig); | ||
|
|
||
| assertEquals(List.of(), openDatabaseAction.getFilesToOpen()); | ||
|
|
||
| // Simulate a scenario where the initial directory is bad and the user directory is good | ||
| when(openDatabaseAction.getFileDialogConfiguration(openDatabaseAction.getInitialDirectory())) | ||
| .thenReturn(badConfig); | ||
| when(openDatabaseAction.getFileDialogConfiguration(Directories.getUserDirectory())) | ||
| .thenReturn(goodConfig); | ||
|
|
||
| assertThrows(IllegalArgumentException.class, () -> dialogService.showFileOpenDialogAndGetMultipleFiles(badConfig)); | ||
| assertDoesNotThrow(() -> dialogService.showFileOpenDialog(goodConfig)); | ||
| assertEquals(List.of(), openDatabaseAction.getFilesToOpen()); | ||
| } | ||
| } |