Jump to entry key cli (WIP)

CHANGELOG.md

@@ -20,6 +20,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We added a fetcher for [LOBID](https://lobid.org/resources/api) resources. [koppor#386](https://github.com/koppor/jabref/issues/386)
 - When in `biblatex` mode, the [integrity check](https://docs.jabref.org/finding-sorting-and-cleaning-entries/checkintegrity) for journal titles now also checks the field `journal`.
 - We added support for pushing citations to [TeXShop](https://pages.uoregon.edu/koch/texshop/) on macOS [forum#2699](https://discourse.jabref.org/t/push-to-texshop-mac/2699).
+- We added ability to jump to an entry in the command line using -j CITATIONKEY [BIBTEXFILES]. [koppor#540](https://github.com/koppor/jabref/issues/540)
 
 ### Changed
 

src/main/java/org/jabref/cli/ArgumentProcessor.java

@@ -277,8 +277,8 @@ public void processArguments() {
             doAuxImport(loaded);
         }
 
-        if (!cli.isBlank() && cli.isJumpToEntryKey()) {
-            jumpToEntryKey(loaded, cli.getJumpToEntryKey());
+        if (!cli.isBlank() && cli.isJumpToKey()) {
+            jumpToKey(loaded, cli.getJumpToKey());
         }
 
         this.parserResults = loaded;
@@ -777,16 +777,15 @@ private Optional<ParserResult> fetch(String fetchCommand) {
         }
     }
 
-    private void jumpToEntryKey(List<ParserResult> loaded, String citationKey) {
-        // search for this key in imported files
+    private void jumpToKey(List<ParserResult> loaded, String citationKey) {
         for (ParserResult parserResult : loaded) {
             Optional<BibEntry> entry = parserResult.getDatabase().getEntryByCitationKey(citationKey);
             if (entry.isPresent()) {
                 parserResult.setEntryToFocus(entry.get());
                 return;
             }
         }
-        LOGGER.error("Could not find given citation key to jump to");
+        System.out.printf("Could not find citation key %s in any library%n", citationKey);
     }
 
     public boolean isBlank() {

src/main/java/org/jabref/cli/JabRefCLI.java

@@ -169,12 +169,12 @@ public String getWriteMetadatatoPdf() {
                         cl.hasOption("embeddBibfileInPdf") ? cl.getOptionValue("embeddBibfileInPdf") : null;
     }
 
-    public String getJumpToEntryKey() {
-        return cl.getOptionValue("jumpToEntryKey");
+    public String getJumpToKey() {
+        return cl.getOptionValue("jumpToKey");
     }
 
-    public boolean isJumpToEntryKey() {
-        return cl.hasOption("jumpToEntryKey");
+    public boolean isJumpToKey() {
+        return cl.hasOption("jumpToKey");
     }
 
     private static Options getOptions() {
@@ -298,10 +298,10 @@ private static Options getOptions() {
 
         options.addOption(Option
                 .builder("j")
-                .longOpt("jumpToEntryKey")
-                .desc(String.format("%s: '%s'", Localization.lang("Jump to the BibEntry of the given key."), "-j key"))
+                .longOpt("jumpToKey")
+                .desc(String.format("%s: '%s'", Localization.lang("Jump to the entry of the given citation key."), "-j key"))
                 .hasArg()
-                .argName("ENTRYKEY")
+                .argName("CITEKEY")
                 .build());
 
         return options;

src/main/java/org/jabref/gui/JabRefGUI.java

@@ -206,7 +206,7 @@ private void openDatabases() {
         boolean focusDifferent = false;
         Optional<BibEntry> focusedEntry = Optional.empty();
         for (ParserResult parserResult : parserResults) {
-            // Make sure this parser result is its own library instead of imported BibTex entries
+            // Make sure this parser result is its own library instead of imported BibTeX entries
             if (parserResult.getEntryToFocus().isPresent() && !parserResult.toOpenTab()) {
                 focusDifferent = true;
                 focusedEntry = parserResult.getEntryToFocus();

src/main/java/org/jabref/gui/LibraryTab.java

@@ -222,7 +222,7 @@ public Node createLoadingAnimationLayout() {
     public void onDatabaseLoadingStarted() {
         Node loadingLayout = createLoadingAnimationLayout();
         getMainTable().placeholderProperty().setValue(loadingLayout);
-        frame.addTab(this, true);
+        frame.addTab(this, false);
     }
 
     public void onDatabaseLoadingSucceed(ParserResult result) {

src/main/java/org/jabref/gui/importer/actions/OpenDatabaseAction.java

@@ -172,9 +172,10 @@ public void openFiles(List<Path> filesToOpen) {
                 openTheFile(theFile);
                 fileHistory.newFile(theFile);
             });
-        } else if (toRaise != null) {
+        } else if (toRaise != null && frame.getCurrentLibraryTab() == null) {
             // If no files are remaining to open, this could mean that a file was
             // already open. If so, we may have to raise the correct tab:
+            // If there is already a library focused, do not show this library
             frame.showLibraryTab(toRaise);
         }
     }

src/main/resources/l10n/JabRef_en.properties

@@ -974,6 +974,8 @@ Write\ BibTeXEntry\ as\ metadata\ to\ PDF.=Write BibTeXEntry as metadata to PDF.
 Write\ metadata\ for\ all\ PDFs\ in\ current\ library?=Write metadata for all PDFs in current library?
 Writing\ metadata...=Writing metadata...
 
+Jump\ to\ the\ entry\ of\ the\ given\ citation\ key.=Jump to the entry of the given citation key.
+
 Embed\ BibTeXEntry\ in\ PDF.=Embed BibTeXEntry in PDF.
 File\ '%0'\ is\ write\ protected.=File '%0' is write protected.
 Write\ BibTeXEntry\ as\ XMP\ metadata\ to\ PDF.=Write BibTeXEntry as XMP metadata to PDF.