Enable UseDiamondOperator (#10963)

JabRef · Mar 3, 2024 · 50249c7 · 50249c7
1 parent 54813e5
commit 50249c7
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/rewrite.yml b/rewrite.yml
@@ -94,8 +94,6 @@ recipeList:
   #  - org.openrewrite.staticanalysis.UseAsBuilder
   # "Upgrades" too much, deletes fields
   #  - org.openrewrite.staticanalysis.UseCollectionInterfaces
-  # Does not work at TreeNode
-  #  - org.openrewrite.staticanalysis.UseDiamondOperator
   # States that it gains performance, but the code is more unreable
   #  - org.openrewrite.staticanalysis.UseForEachRemoveInsteadOfSetRemoveAll
   # We voted against it
@@ -189,6 +187,7 @@ recipeList:
   - org.openrewrite.staticanalysis.TypecastParenPad
   - org.openrewrite.staticanalysis.UnwrapRepeatableAnnotations
   - org.openrewrite.staticanalysis.UpperCaseLiteralSuffixes
+  - org.openrewrite.staticanalysis.UseDiamondOperator
 #  - org.openrewrite.staticanalysis.UseJavaStyleArrayDeclarations
   - org.openrewrite.staticanalysis.UseLambdaForFunctionalInterface
 #  - org.openrewrite.staticanalysis.UseListSort

diff --git a/src/main/java/org/jabref/gui/fieldeditors/MapBasedEditorViewModel.java b/src/main/java/org/jabref/gui/fieldeditors/MapBasedEditorViewModel.java
@@ -30,7 +30,7 @@ public MapBasedEditorViewModel(Field field, SuggestionProvider<?> suggestionProv
 
     @Override
     public StringConverter<T> getStringConverter() {
-        return new StringConverter<T>() {
+        return new StringConverter<>() {
             @Override
             public String toString(T object) {
                 if (object == null) {

diff --git a/src/main/java/org/jabref/gui/util/DefaultTaskExecutor.java b/src/main/java/org/jabref/gui/util/DefaultTaskExecutor.java
@@ -141,7 +141,7 @@ public DelayTaskThrottler createThrottler(int delay) {
     }
 
     private <V> Task<V> getJavaFXTask(BackgroundTask<V> task) {
-        Task<V> javaTask = new Task<V>() {
+        Task<V> javaTask = new Task<>() {
             {
                 this.updateMessage(task.messageProperty().get());
                 this.updateTitle(task.titleProperty().get());

diff --git a/src/main/java/org/jabref/gui/util/ViewModelTreeTableCellFactory.java b/src/main/java/org/jabref/gui/util/ViewModelTreeTableCellFactory.java
@@ -51,7 +51,7 @@ public ViewModelTreeTableCellFactory<S> withOnMouseClickedEvent(
 
     @Override
     public TreeTableCell<S, S> call(TreeTableColumn<S, S> param) {
-        return new TreeTableCell<S, S>() {
+        return new TreeTableCell<>() {
             @Override
             protected void updateItem(S viewModel, boolean empty) {
                 super.updateItem(viewModel, empty);

diff --git a/src/test/java/org/jabref/model/paging/PageTest.java b/src/test/java/org/jabref/model/paging/PageTest.java
@@ -24,8 +24,8 @@ public class PageTest {
     public void setup() {
         testContent.addAll(Arrays.asList(testStrings));
         testContent = Collections.unmodifiableCollection(testContent);
-        page1 = new Page<String>(testQuery, testPageNumber, testContent);
-        page2 = new Page<String>(testQuery, testPageNumber);
+        page1 = new Page<>(testQuery, testPageNumber, testContent);
+        page2 = new Page<>(testQuery, testPageNumber);
     }
 
     @Test