Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more secrete presence checks #11060

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Add more secrete presence checks #11060

merged 1 commit into from
Mar 20, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Mar 20, 2024

The tests at #10995 were failing for the EA build. I think, I just missed some secrets precense checks.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Contributor

github-actions bot commented Mar 20, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Mar 20, 2024
Merged via the queue into main with commit 82a0338 Mar 20, 2024
27 checks passed
@Siedlerchr Siedlerchr deleted the fix-ea branch March 20, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants