Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep DJL on 0.29.0 #11790

Closed
wants to merge 2 commits into from
Closed

Keep DJL on 0.29.0 #11790

wants to merge 2 commits into from

Conversation

koppor
Copy link
Member

@koppor koppor commented Sep 18, 2024

Alternative to #11789

This reverts #11773 and prevents dependabot updates.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the component: ai Related to AI Chat/Summarization label Sep 18, 2024
Copy link
Contributor

github-actions bot commented Sep 18, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor
Copy link
Member Author

koppor commented Sep 18, 2024

An error occurred while building the embedding model
java.lang.Exception: java.util.ServiceConfigurationError: ai.djl.repository.RepositoryFactory: module org.jabref.merged.module does not declare `uses`
	at [email protected]/org.jabref.gui.util.UiTaskExecutor.convertToException(Unknown Source)
	at [email protected]/org.jabref.gui.util.UiTaskExecutor.lambda$getJavaFXTask$4(Unknown Source)
	at javafx.base@23/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(Unknown Source)
	at javafx.base@23/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
	at javafx.base@23/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
	at javafx.base@23/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
	at javafx.base@23/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
	at javafx.base@23/com.sun.javafx.event.EventUtil.fireEventImpl(Unknown Source)
	at javafx.base@23/com.sun.javafx.event.EventUtil.fireEvent(Unknown Source)
	at javafx.base@23/javafx.event.Event.fireEvent(Unknown Source)
	at javafx.graphics@23/javafx.concurrent.EventHelper.fireEvent(Unknown Source)
	at javafx.graphics@23/javafx.concurrent.Task.fireEvent(Unknown Source)
	at javafx.graphics@23/javafx.concurrent.Task.setState(Unknown Source)
	at javafx.graphics@23/javafx.concurrent.Task$TaskCallable.lambda$call$2(Unknown Source)
	at javafx.graphics@23/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at javafx.graphics@23/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(Unknown Source)
	at javafx.graphics@23/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(Unknown Source)
	at javafx.graphics@23/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
	at javafx.graphics@23/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.util.ServiceConfigurationError: ai.djl.repository.RepositoryFactory: module org.jabref.merged.module does not declare `uses`
	at java.base/java.util.ServiceLoader.fail(Unknown Source)
	at java.base/java.util.ServiceLoader.checkCaller(Unknown Source)
	at java.base/java.util.ServiceLoader.<init>(Unknown Source)
	at java.base/java.util.ServiceLoader.load(Unknown Source)
	at [email protected]/ai.djl.repository.RepositoryFactoryImpl.init(Unknown Source)
	at [email protected]/ai.djl.repository.RepositoryFactoryImpl.<clinit>(Unknown Source)
	at [email protected]/ai.djl.repository.Repository.newInstance(Unknown Source)
	at [email protected]/ai.djl.engine.rust.zoo.RsModelZoo.<clinit>(Unknown Source)
	at [email protected]/ai.djl.engine.rust.zoo.RsZooProvider.getModelZoo(Unknown Source)
	at [email protected]/ai.djl.repository.zoo.ModelZoo.registerModelZoo(Unknown Source)
	at [email protected]/ai.djl.repository.zoo.ModelZoo.<clinit>(Unknown Source)
	at [email protected]/ai.djl.repository.zoo.Criteria$Builder.optModelUrls(Unknown Source)
	at [email protected]/org.jabref.logic.ai.ingestion.model.UpdateEmbeddingModelTask.call(Unknown Source)
	at [email protected]/org.jabref.logic.ai.ingestion.model.UpdateEmbeddingModelTask.call(Unknown Source)
	at [email protected]/org.jabref.gui.util.UiTaskExecutor$1.call(Unknown Source)
	at javafx.graphics@23/javafx.concurrent.Task$TaskCallable.call(Unknown Source)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	... 1 more

@ThiloteE
Copy link
Member

I tested this PR's AI functionality and it works on my Windows 10 machine with a Nvidia Geforece GTX 1060 3GB. I ran JabRef with gradlew run.

@koppor
Copy link
Member Author

koppor commented Sep 18, 2024

Since #11789 also works for @ThiloteE, closing this.

@koppor koppor closed this Sep 18, 2024
@koppor koppor deleted the other-downgrade branch September 18, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ai Related to AI Chat/Summarization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants