Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump luceneVersion from 9.11.1 to 9.12.0 #11888

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 7, 2024

Bumps luceneVersion from 9.11.1 to 9.12.0.
Updates org.apache.lucene:lucene-core from 9.11.1 to 9.12.0

Updates org.apache.lucene:lucene-queryparser from 9.11.1 to 9.12.0

Updates org.apache.lucene:lucene-queries from 9.11.1 to 9.12.0

Updates org.apache.lucene:lucene-analysis-common from 9.11.1 to 9.12.0

Updates org.apache.lucene:lucene-highlighter from 9.11.1 to 9.12.0

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `luceneVersion` from 9.11.1 to 9.12.0.

Updates `org.apache.lucene:lucene-core` from 9.11.1 to 9.12.0

Updates `org.apache.lucene:lucene-queryparser` from 9.11.1 to 9.12.0

Updates `org.apache.lucene:lucene-queries` from 9.11.1 to 9.12.0

Updates `org.apache.lucene:lucene-analysis-common` from 9.11.1 to 9.12.0

Updates `org.apache.lucene:lucene-highlighter` from 9.11.1 to 9.12.0

---
updated-dependencies:
- dependency-name: org.apache.lucene:lucene-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.lucene:lucene-queryparser
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.lucene:lucene-queries
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.lucene:lucene-analysis-common
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.lucene:lucene-highlighter
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dev: dependencies Pull requests that update a dependency file label Oct 7, 2024
jabref-machine
jabref-machine previously approved these changes Oct 7, 2024
@koppor koppor enabled auto-merge October 7, 2024 14:43
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.

You can check review dog's comments at the tab "Files changed" of your pull request.

@LoayGhreeb LoayGhreeb disabled auto-merge October 7, 2024 16:13
Copy link
Contributor

github-actions bot commented Oct 7, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@LoayGhreeb LoayGhreeb requested a review from koppor October 7, 2024 16:29
@Siedlerchr
Copy link
Member

There is one thing that mabye needs adaption:
https://lucene.apache.org/core/9_12_0/changes/Changes.html#v9.12.0.changes_in_runtime_behavior

GITHUB#13472: When an executor is provided to the IndexSearcher constructor, the searcher now executes tasks on the thread that invoked a search as well as its configured executor. Users should reduce the executor's thread-count by 1 to retain the previous level of parallelism. Moreover, it is now possible to start searches from the same executor that is configured in the IndexSearcher without risk of deadlocking. A separate executor for starting searches is no longer required.

@Siedlerchr
Copy link
Member

We merge now and tackle executor changes in a follow up PR

@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 766fa6b Oct 8, 2024
30 of 31 checks passed
@Siedlerchr Siedlerchr deleted the dependabot/gradle/luceneVersion-9.12.0 branch October 8, 2024 16:02
Siedlerchr added a commit that referenced this pull request Oct 8, 2024
* upstream/main:
  Bump luceneVersion from 9.11.1 to 9.12.0 (#11888)
  Bump buildres/abbrv.jabref.org from `234cce8` to `6ec4cd0` (#11899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants