-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Entry Editor #12210
base: main
Are you sure you want to change the base?
Extract Entry Editor #12210
Conversation
fe21d9b
to
f247c7c
Compare
# Conflicts: # src/main/java/org/jabref/gui/frame/JabRefFrame.java
Related historic PRs:
Side note: I found the PR for the maintable JavaFX migration: #3621 (and #3591) |
There can only be one. |
Works fine for me. Although I noticed some exception logs (not related to these changes) appearing when I double click on an entry to bring up the editor after startup. |
# Conflicts: # src/main/java/org/jabref/gui/frame/JabRefFrame.java
The build of this PR is available at https://builds.jabref.org/pull/12210/merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I close the last tab, entry editor needs to be closed, too:
Entry editor does not respect mode on first show
Reproduce: test files of #12510 -> open entry-editor-tabs-bibtex.bib
(If I open both and switch back and forth, it works)
Instead of having an instance of the EntryEditor for every LibraryTab - one is enough. One EntryEditor to rule them all, one EntryEditor to find them, one Entryeditor to bring them all and in the bottom of the interface bind them.
Introduced
Todo:
Move Open/Close of EntryEditor to JabRefFrameAdapt EntryEditor to follow observables and to tolerate no entryAdapt StateManager from DatabaseContext to LibraryTab? (invalid)Fix remaining bugs:Not showing anythingNPE on exitOpen entry editor menu itemEntry editor maximized when openGoal:
Level of abstraction (StateManager should use LibraryTab instead of BibDatabaseContext)postponed to later pr. would overload this one
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)