Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method name #12322

Merged
merged 1 commit into from
Dec 21, 2024
+3 −3
Merged

Fix method name #12322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...main/java/org/jabref/gui/preferences/externalfiletypes/ExternalFileTypesTabViewModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public boolean edit(ExternalFileTypeItemViewModel type) {
showEditDialog(typeToModify, Localization.lang("Edit file type"));

if (type.extensionProperty().get().equals(typeToModify.extensionProperty().get())) {
if (withEmptyValue(typeToModify)) {
if (hasEmptyValue(typeToModify)) {
LOGGER.warn("One of the fields is empty or invalid. Not saving.");
return false;
}
Expand All @@ -101,7 +101,7 @@ public void remove(ExternalFileTypeItemViewModel type) {
}

public boolean isValidExternalFileType(ExternalFileTypeItemViewModel item) {
if (withEmptyValue(item)) {
if (hasEmptyValue(item)) {
LOGGER.warn("One of the fields is empty or invalid. Not saving.");
return false;
}
Expand All @@ -114,7 +114,7 @@ public boolean isValidExternalFileType(ExternalFileTypeItemViewModel item) {
return true;
}

private boolean withEmptyValue(ExternalFileTypeItemViewModel item) {
private boolean hasEmptyValue(ExternalFileTypeItemViewModel item) {
return item.getName().isEmpty() || item.extensionProperty().get().isEmpty() || item.mimetypeProperty().get().isEmpty();
}

Expand Down
Loading