Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change mac icon #12325

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Change mac icon #12325

merged 2 commits into from
Dec 23, 2024

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Dec 22, 2024 •
edited
Loading

Fixes #8443

grafik grafik

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 22, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

subhramit
subhramit approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@subhramit subhramit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my mac
image

@Siedlerchr Siedlerchr added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit b464034 Dec 23, 2024
27 of 28 checks passed
@Siedlerchr Siedlerchr deleted the macIcon branch December 23, 2024 08:21
ar-rana pushed a commit to ar-rana/jabref that referenced this pull request Dec 26, 2024
@Siedlerchr @ar-rana
Change mac icon (JabRef#12325)
ce258c3 
* Change mac icon

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subhramit subhramit subhramit approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macOS icon is inconsistent with other application icons
2 participants
@Siedlerchr @subhramit