Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine comments #12334

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Refine comments #12334

merged 3 commits into from
Dec 23, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Dec 23, 2024

Follow-up to #12324

Some more code comments - in case someone touches the source again.

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor requested a review from Siedlerchr December 23, 2024 16:22
Siedlerchr
Siedlerchr previously approved these changes Dec 23, 2024
View reviewed changes
src/main/java/org/jabref/gui/linkedfile/DeleteFileAction.java Outdated Show resolved Hide resolved
@Siedlerchr Siedlerchr enabled auto-merge December 23, 2024 16:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Dec 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 23, 2024
@Siedlerchr Siedlerchr added this pull request to the merge queue Dec 23, 2024
@Siedlerchr Siedlerchr removed this pull request from the merge queue due to a manual request Dec 23, 2024
@Siedlerchr Siedlerchr merged commit 0892724 into main Dec 23, 2024
26 checks passed
@Siedlerchr Siedlerchr deleted the follow-up-12324 branch December 23, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koppor @Siedlerchr