Skip to content

Reorder settings in the Entry editor tab in preferences and buttons to hide AI tabs #12919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 17, 2025

Conversation

priyanshu16095
Copy link
Contributor

@priyanshu16095 priyanshu16095 commented Apr 10, 2025

Closes #11707

This PR reorders the settings in the Entry Editor tab and adds buttons in the Privacy Notice and Related Articles tabs in the Entry Editor for hiding AI-related tabs.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Screenshot (325)
image
image

@priyanshu16095
Copy link
Contributor Author

Recording.2025-04-11.mp4

@priyanshu16095
Copy link
Contributor Author

What to add in the changelog as one thing was changed and one thing was added?

@Siedlerchr
Copy link
Member

One line under Added and one under Changed., the latter e.g. We improved the AI related setttings

Copy link

trag-bot bot commented Apr 13, 2025

@trag-bot didn't find any issues in the code! ✅✨


@FXML
private void hideAITabs() {
EntryEditorPreferences entryEditorPreferences = preferences.getEntryEditorPreferences();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calixtus do we need this restart?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically this comes in effect when you reopen the editor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Live updated implemented in #12958

@Siedlerchr Siedlerchr added this pull request to the merge queue Apr 17, 2025
Merged via the queue into JabRef:main with commit 8ffe3d0 Apr 17, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Do not show AI tabs" to AI tabs
4 participants