Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grobid config panel without checkbox #9802

Closed
wants to merge 11 commits into from

Conversation

hanachaari
Copy link

@hanachaari hanachaari commented Apr 25, 2023

This fixes a koppor issue #566 related to Grobid preferences.The link:
Fixes JabRef#566 .
I have changed Grobid preferences from a checkbox to a Radio-Button-Group (disable, enable, always ask).

This is the new configuration panel
image
image
image

The dialog below appears as long as the user does not check "do not ask again" or change preferences .
image

Despite the decision as mentioned here JabRef#566 (comment) was to remove the "do not ask checkbox", I think it is not recommended from a UX perspective. So, I provided two versions: the branch: "gorbidConfigPanel" without a checkbox and the branch"gorbidConfigPanelWithCheckBox" with a checkbox.
The checkbox in the later branch is synchronized so when it is checked Grobid preferences will be "disabled" or "enabled" according to the user's answer(yes/no).

Compulsory checks

Preview Give feedback

@hanachaari hanachaari closed this Apr 25, 2023
@koppor
Copy link
Member

koppor commented Apr 26, 2023

The PR currently worked on is #9801

@hanachaari
Copy link
Author

I have continued working on this branch since it does not have the checkbox. I agree with Tobias' s comment #9291 (comment). So I have changed the behavior this way:
Upon the first use no preference is selected
image

With the first import this dialog is displayed
image

Depending on the answer, set the preference to "enable" or "disabled".(yes in the case)
image

Thereafter, the user will not be asked again unless he resets preferences.

@koppor
Copy link
Member

koppor commented Apr 28, 2023

I double checked the casing of Grobid.

They say, "Grobid" is also OK.

image

(Source: https://github.com/kermitt2/grobid#grobid-documentation) Sorry for my wrong demand for "GROBID"

I noticed the inconsistency here:

image

@koppor
Copy link
Member

koppor commented Apr 28, 2023

Please address the comments by @calixtus from the PR #9801 (comment)

After our discussions here, issue refinements, the task is different:

  1. Keep preference appearance as is:

image

There is already the boolean setting.

  1. Modify the logic when the dialog appears:

grafik

Instead of "Do not ask again", the dialog should only appear upon first start ever in JabRef. This should be recorded in the preferences. I think, we need a new preference key (internal storage) for that. In that way, no migration is necessary. (Adressing the comment #9801 (comment))

@Siedlerchr Siedlerchr added the status: changes required Pull requests that are not yet complete label May 4, 2023
@hanachaari
Copy link
Author

I am implementing the preferences in the tab directly now. However, I faced a problem when I was running the tests. Some tests(Tests/Unit tests) failed because I am working on Windows so paths are not recognized which caused the failure of the test.

@calixtus
Copy link
Member

If you push your changes to GitHub, we can see your changes and maybe help. Please also merge the current main branch into your brach, since we just recently hat a major change in the preferences UI. The Importexport tab has been dissolved and it's content moved to other panels.

@calixtus
Copy link
Member

Closing this PR due to inactivity 💤
Please reopen a PR if you intend to continue on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences status: changes required Pull requests that are not yet complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unchecked "Do not ask again" does not work
5 participants