Print logs once #52
Merged
Print logs once #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, experiment log handlers were added not at root, but at the experiment step's node. Since we want to capture all logs, the handlers were instead added to the root logger. However, when there was more than one step, this added multiple identical handlers emitting copies of the same logrecords. Now, the logging configuration is only handled in the trial setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, experiment log handlers were added not at root logger, but at the
logger for each step's module. Later, we realized we wanted to capture all
logs, so the handlers instead got added to the root logger. However, when
there was more one step, this added an identical handler to root for each step,
thus emitting copies of same logrecords.
Now, the logging configuration is only handled in the trial setup.
Tests modified as well to check not only that requisite message is in log, but that it only occurs once
@yb6599 @MalachiteWind