submission hw3 #11
Open
submission hw3 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereator
reviewed
Dec 4, 2020
| // --- PUT YOUR CODE HERE --- | ||
|
|
There was a problem hiding this comment.
The case when the plane is orthogonal to one of the axises?
| res.extend(m_a); | ||
| res.extend(m_b); | ||
| res.extend(m_c); | ||
| res.m_minPoint = std::numeric_limits<Vec3f>::infinity(); |
There was a problem hiding this comment.
Why did you add these two lines ?
| @@ -68,6 +68,9 @@ class CPrimSphere : public IPrim | |||
| { | |||
| CBoundingBox res; | |||
| // --- PUT YOUR CODE HERE --- | |||
| res.extend(m_origin + Vec3f(m_radius, m_radius, m_radius)); | |||
There was a problem hiding this comment.
You need to add the -radius as well
| @@ -68,6 +68,9 @@ class CPrimSphere : public IPrim | |||
| { | |||
| CBoundingBox res; | |||
| // --- PUT YOUR CODE HERE --- | |||
| res.extend(m_origin + Vec3f(m_radius, m_radius, m_radius)); | |||
| res.m_minPoint = std::numeric_limits<Vec3f>::infinity(); | |||
| res.m_maxPoint = std::numeric_limits<Vec3f>::infinity() * (-1); | |||
There was a problem hiding this comment.
Why did you add these two lines ?
| Vec3f pointLightIntensity(3, 3, 3); | ||
| Vec3f lightPosition2(-3, 5, 4); | ||
| Vec3f lightPosition3(0, 1, 4); | ||
|
|
||
| scene.add(std::make_shared<CLightOmni>(pointLightIntensity, lightPosition2)); | ||
| scene.add(std::make_shared<CLightOmni>(pointLightIntensity, lightPosition3)); | ||
|
|
||
| Mat img(resolution, CV_32FC3); // image array | ||
| Ray ray; // primary ray |
There was a problem hiding this comment.
Ray should lie inside the parallel part of the code
| @@ -72,7 +72,6 @@ class CBoundingBox | |||
| */ | |||
| Vec3f getMaxPoint(void) const { return m_maxPoint; } | |||
|
|
|||
| private: | |||
There was a problem hiding this comment.
Why did you delete this line ?
There was a problem hiding this comment.
because I was using one of the private variables in another class and it was not accessible. I know I could have used static casting or get method, but this was giving me an error at submission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.