Updated installation instructions #744
Conversation
| <pre class="prettyprint"> | ||
| buildscript { | ||
| repositories { | ||
| mavenCentral() |
There was a problem hiding this comment.
For buildscript repositories, you do not need mavenCentral(). Also, with the android gradle plugin 2.2.0 out, you do not need android-apt. You can use the annotation processor that comes with it.
|
|
||
| dependencies { | ||
| compile 'com.jakewharton:butterknife:<span class="version"><em>(insert latest version)</em></span>' |
There was a problem hiding this comment.
Put 8.4.0, the latest version.
There was a problem hiding this comment.
There is actually a piece of Javascript which loads the latest version automatically, but this is not working on GH pages, so hence better to add a fixed version.
|
Incorporated your feedback, Android plugin v2.2.0 stable is now available so made that the default installation instructions. Also updated the README to use the built in annotation processor by default. Note that I removed the requirement to use Jack as this doesn't seem to be necessary. |
|
@JeroenMols Looks great! I have a PR in parallel with this one: #749 that uses the latest plugin. |
| classpath 'com.neenbedankt.gradle.plugins:android-apt:1.8' | ||
| } | ||
| ... | ||
| dependencies { |
| } | ||
| ... | ||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:2.2.0' // 2.2.0 or higher |
There was a problem hiding this comment.
Comment is redundant with the sentence above and people will end up copy/pasting it into build files. Let's remove.
| buildscript { | ||
| ... | ||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:2.2.0' // 2.2.0 or higher |
| <pre class="prettyprint"> | ||
| dependencies { | ||
| compile 'com.jakewharton:butterknife:8.4.0</span>' | ||
| annotationProcessor 'com.jakewharton:butterknife-compiler:8.4.0</em></span>' |
There was a problem hiding this comment.
Both of these should use <span class="version"><em>(latest version)</em></span> for the version.
There was a problem hiding this comment.
Added this change, works locally on my device, but not on Github pages it seems,
https://jakewharton.github.io/butterknife
There was a problem hiding this comment.
Probably needs to use https?
There was a problem hiding this comment.
Only thing that isn't https is the ajax script:
<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.9.1/jquery.min.js"></script>Shall I change that to https? (I'm not a web guru so just guessing...)
There was a problem hiding this comment.
Someone fixed this on another project. I'll have to go track it down.
There was a problem hiding this comment.
Side note: also okhttp, okio, retrofit, picasso and dagger have the same issue
| <pre class="prettyprint"> | ||
| buildscript { | ||
| ... | ||
| dependencies { |
|
Incorporated review feedback |
| <pre class="prettyprint"> | ||
| dependencies { | ||
| compile 'com.jakewharton:butterknife:<span class="version"><em>(latest version)</em></span></span>' | ||
| annotationProcessor 'com.jakewharton:butterknife-compiler:<span class="version"><em>(latest version)</em></span></em></span>' |
There was a problem hiding this comment.
You have an extra </em></span> here
|
Sorry for the late reply, didn't see I still had stuff to fix |
|
It was approved but not merged why? There is quite a lot open pull request without any explanation why it was not merged :-( |
Website currently doesn't mention use of apt plugin, hence not providing a complete solution to get ButterKnife up and running.
Note: the apt-plugin version is static (but I saw the JS versioning isn't working on github pages)