Skip to content

Commit

Permalink
Merge branch 'master' of https://github.com/JamesHeinrich/getID3
Browse files Browse the repository at this point in the history
  • Loading branch information
JamesHeinrich committed Sep 20, 2024
2 parents ded8b13 + 78dc28a commit eb358a0
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 6 deletions.
14 changes: 14 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Dependabot configuration.
#
# Please see the documentation for all configuration options:
# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates

version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
open-pull-requests-limit: 5
commit-message:
prefix: "GH Actions:"
8 changes: 4 additions & 4 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
php-version: "${{ matrix.php-version }}"
ini-values: error_reporting=-1, display_errors=On
coverage: "none"
- uses: "ramsey/composer-install@v2"
- uses: "ramsey/composer-install@v3"
with:
composer-options: "${{ matrix.composer-options }}"
- name: "Run the linter"
Expand All @@ -51,8 +51,8 @@ jobs:
- uses: "shivammathur/setup-php@v2"
with:
php-version: "8.2"
tools: "phpstan:1.10.57"
tools: "phpstan:1.12.3"
coverage: "none"
- uses: "ramsey/composer-install@v2"
- uses: "ramsey/composer-install@v3"
- name: "Run PHPStan"
run: "phpstan analyse -c phpstan.neon -l 4 getid3"
run: "phpstan"
2 changes: 1 addition & 1 deletion getid3/module.audio-video.quicktime.php
Original file line number Diff line number Diff line change
Expand Up @@ -1653,7 +1653,7 @@ public function QuicktimeParseAtom($atomname, $atomsize, $atom_data, $baseoffset
@list($all, $latitude, $longitude, $altitude) = $matches;
$info['quicktime']['comments']['gps_latitude'][] = floatval($latitude);
$info['quicktime']['comments']['gps_longitude'][] = floatval($longitude);
if (!empty($altitude)) {
if (!empty($altitude)) { // @phpstan-ignore-line
$info['quicktime']['comments']['gps_altitude'][] = floatval($altitude);
}
} else {
Expand Down
2 changes: 1 addition & 1 deletion getid3/module.audio-video.riff.php
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public function Analyze() {
$info['avdataend'] = $info['filesize'];
}

$nextRIFFoffset = $Original['avdataoffset'] + 8 + $thisfile_riff['header_size']; // 8 = "RIFF" + 32-bit offset
$nextRIFFoffset = (int) $Original['avdataoffset'] + 8 + (int) $thisfile_riff['header_size']; // 8 = "RIFF" + 32-bit offset
while ($nextRIFFoffset < min($info['filesize'], $info['avdataend'])) {
try {
$this->fseek($nextRIFFoffset);
Expand Down
3 changes: 3 additions & 0 deletions phpstan.neon
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
parameters:
level: 4
paths:
- getid3
excludes_analyse:
polluteScopeWithLoopInitialAssignments: true
dynamicConstantNames:
Expand Down

0 comments on commit eb358a0

Please sign in to comment.